Fixes block form of #start + add specs #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcamara
force-pushed
the
fix-json-structure-in-block-format
branch
from
9c7c469 to
64a9ac8
Compare
* Because the ensure calls `_stop` instead of `stop`, the block form produces invalid json * Perfetto is pretty permissive about this and still accepts the file - but other tools break and JSON parsing is broken * Also adds first specs for the project, covering a few different scenarios 🎉
jpcamara
force-pushed
the
fix-json-structure-in-block-format
branch
from
64a9ac8 to
23ce67b
Compare
ivoanjo
approved these changes
Dec 9, 2023
|
Interestingly, even without MN, some of the tests break on 3.3 in CI . It's no worse than it was before so at least now we know about it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the ensure calls
_stopinstead ofstop, the block form produces invalid jsonPerfetto is pretty permissive about this and still accepts the file - but other tools break and JSON parsing is broken
Also adds first specs for the project, covering a few different scenarios 🎉