Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit .buildinfo file #618

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

michaelaird
Copy link
Contributor

This is a first step in supporting incremental builds

@michaelaird
Copy link
Contributor Author

@ivogabe I can't figure out why these tests are failing. Can you have a look?

@arieldf
Copy link

arieldf commented Jul 1, 2019

@ivogabe I would really like this to be merged. Anything I can assist with?

@boenrobot
Copy link

boenrobot commented Sep 9, 2019

I would really like this to be merged as well...

From what I can see, the file "test/tsConfigIncremental/gulptask.js" is triggered for all TS versions, but since there is no tsbuildinfo in versions earlier than 3.4, the tests fail, because earlier TS versions don't just ignore the unknown option, but complain about it instead.

To fix this, one must either strip the unknown option for versions prior to 3.4, or make the test detect 3.4, and skip it if it's earlier. I'm not entirely sure how do either of those things... I'm just pointing out the cause.

For detecting version and skipping tests, I think perhaps if this line is modified to also pass in the version, the test can check it from its start and just return right there.

Added a version check for the incremental test.
@boenrobot
Copy link

Hmm... it looks like tsbuildinfo contains full paths, which is why the paths from my PC leaked into the test baseline for this... oops. And I'm not sure what's going on with the other error, but suffice it to say the baseline should probably be adjusted to match the test.

@ivogabe
Copy link
Owner

ivogabe commented Sep 12, 2019

I’ll try to take a look at this in the weekend.

@boenrobot
Copy link

boenrobot commented Sep 13, 2019

BTW, I tried to actually use this, and there's a problem with it - if the tsconfig.json does not define an outFile, no buildinfo is emitted.

If you use tsc from the command line, you do get it, so this is a bug with this PR or TS as a lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants