Modify <html> tag Regex #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2020 16:49
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 97.18% 97.18%
Complexity 557 557
=========================================
Files 5 5
Lines 888 888
=========================================
Hits 863 863
Misses 25 25
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a number of
The
</div>is being replaced with<html5-dom-document-internal-cdata-endtagfix/div>. This is later tripping thepreg_match('/\<html.*?\>/', $source, $matches);regex causing an unnecessary replacement.Due to the ordering these are undone, the resulting html has a number of extra
<head><meta data-html5-dom-document-internal-attribute="charset-meta" http-equiv="content-type" content="text/html; charset=utf-8" />preceding the</div>tags.I believe the contained changes to the
<html>match regex fix this issue by requiring the<htmlto be following by a space or>.