Switch Android SDK 29 deprecated methods to alternatives (ivpusic#1110) #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-flyclops
changed the title
phil-flyclops
force-pushed
the
master
branch
2 times, most recently
from
b35dfd8 to
d533352
Compare
Android SDK 29 deprecated the following method for getting external directories that we use repeatedly. https://developer.android.com/reference/android/os/Environment#getExternalStoragePublicDirectory(java.lang.String) I converted the various use cases to use the suggested alternative in the Context API. https://developer.android.com/reference/android/content/Context.html#getExternalFilesDir(java.lang.String)
phil-flyclops
force-pushed
the
master
branch
from
d533352 to
10d9d94
Compare
|
Let's merge this? As the user base on Android 10 is growing, facing more and more failures due to lack of this fix... |
|
thanks a lot! merged with #1284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android SDK 29 deprecated the following method for getting external directories
that we use repeatedly.
https://developer.android.com/reference/android/os/Environment#getExternalStoragePublicDirectory(java.lang.String)
I converted the various use cases to use the suggested alternative in
the Context API.
https://developer.android.com/reference/android/content/Context.html#getExternalFilesDir(java.lang.String)