CocoaPods - Properly Interpolate Tag Version #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why?
* Ruby uses `"` quotes when interpolation is required. Using `'` will mean `v#{version}`
is used directly rather than providing the version number.
Changes:
1. User Ruby string interpolation when setting the tag version for the source.
ivpusic
approved these changes
Jan 2, 2020
|
thanks |
ivpusic
pushed a commit
that referenced
this pull request
May 1, 2020
Why?
* Ruby uses `"` quotes when interpolation is required. Using `'` will mean `v#{version}`
is used directly rather than providing the version number.
Changes:
1. User Ruby string interpolation when setting the tag version for the source.
ivpusic
added a commit
that referenced
this pull request
May 1, 2020
* Switch Android SDK 29 deprecated methods to alternatives (#1110) Android SDK 29 deprecated the following method for getting external directories that we use repeatedly. https://developer.android.com/reference/android/os/Environment#getExternalStoragePublicDirectory(java.lang.String) I converted the various use cases to use the suggested alternative in the Context API. https://developer.android.com/reference/android/content/Context.html#getExternalFilesDir(java.lang.String) * Updated podspec * Added iOS 13 DarkMode for picker (#1129) * Update README.md * version bump * Removed isMovingToParentViewController so scroll to bottom works (#1137) * Fix deprecated RCTImageLoader.h import (#1142) * upgrade example project to react-native 0.61 * version bump * Update README.md * Fix crash after video recording in ios13 & xcode11 (#1145) * Fix crash after video recording in ios13 & xcode11 UI-related code should run in main thread, as exception says: `Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'threading violation: expected the main thread'` * Typo fix * Fix xCode warnings about main thread execution (#1146) This kind of warnings also presents in output console if Main Thread Checker is active * ignore iml files * version bump * Fix typo (#1150) Changed the word "noticable" to "noticeable". * update type (#1200) * CocoaPods - Properly Interpolate Tag Version (#1174) Why? * Ruby uses `"` quotes when interpolation is required. Using `'` will mean `v#{version}` is used directly rather than providing the version number. Changes: 1. User Ruby string interpolation when setting the tag version for the source. * small typing improvements * version bump * fix typings for writeTempFile * version bump * (ios) changing images sort order * upgrade react-native-cli * using local QBImagePicker as podspec * Update README.md (#1265) Clarify that avoidEmptySpaceAroundImage option is (ios only) * testing with sdk 29 * update yarn.lock * version bump Co-authored-by: Phil Simmons <phil@flyclops.com> Co-authored-by: Yury Korzun <yury@flyclops.com> Co-authored-by: cr1s3c <yannre1210@gmail.com> Co-authored-by: Filipe Merker <filipesmerker@gmail.com> Co-authored-by: Artur Eshenbrener <strate@yandex.ru> Co-authored-by: Suraneti Rodsuwan <suraneti.rod@gmail.com> Co-authored-by: mikunimaru <43168745+mikunimaru@users.noreply.github.com> Co-authored-by: Peter Lucak <login@peterlucak.com> Co-authored-by: Ivan Pusic <ivpusic@users.noreply.github.com> Co-authored-by: Mujtaba F. Radhi <al.mujtaba@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced an issue today where CocoaPods could not properly install this library because the tag version was incorrect. This should fix that!
Why?
"quotes when interpolation is required. Using'will meanv#{version}is used directly rather than providing the version number.
Changes: