-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README about Android SDK version #1887
Conversation
README.md
Outdated
@@ -277,6 +270,9 @@ android { | |||
|
|||
Reference for more details https://github.com/ivpusic/react-native-image-crop-picker/issues/1406 | |||
|
|||
- If you use SDK version 33, add following to `app/src/main/AndroidManifest.xml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be SDK version >= 33
@@ -277,6 +270,9 @@ android { | |||
|
|||
Reference for more details https://github.com/ivpusic/react-native-image-crop-picker/issues/1406 | |||
|
|||
- If you use SDK version 33, add following to `app/src/main/AndroidManifest.xml` | |||
- `<uses-permission android:name="android.permission.READ_MEDIA_IMAGES"/>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need android.permission.READ_EXTERNAL_STORAGE
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivpusic Could you help to review? This README update is important for users who using Android >= 33 |
#4513) [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-image-crop-picker](https://togithub.com/ivpusic/react-native-image-crop-picker) | [`^0.35.1` -> `^0.40.2`](https://renovatebot.com/diffs/npm/react-native-image-crop-picker/0.35.2/0.40.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-image-crop-picker/0.40.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-image-crop-picker/0.40.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-image-crop-picker/0.35.2/0.40.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-image-crop-picker/0.35.2/0.40.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ivpusic/react-native-image-crop-picker (react-native-image-crop-picker)</summary> ### [`v0.40.2`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.40.2) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.40.1...v0.40.2) #### What's Changed - Update README about Android SDK version by [@​pnthach95](https://togithub.com/pnthach95) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1887](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1887) - Fix handling of deleted photos on iOS by [@​brsaylor2](https://togithub.com/brsaylor2) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1556](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1556) #### New Contributors - [@​brsaylor2](https://togithub.com/brsaylor2) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1556](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1556) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.40.1...v0.40.2 ### [`v0.40.1`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.40.1) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.40.0...v0.40.1) #### What's Changed - fix spelling error in readme.md by [@​therealrinku](https://togithub.com/therealrinku) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1953](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1953) - Property 'Latitude' does not exist on type 'object' in exif by [@​dipanjanpanja6](https://togithub.com/dipanjanpanja6) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1964](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1964) - docs: readme typo fix by [@​therealrinku](https://togithub.com/therealrinku) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1979](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1979) - \[revert] Fix for openPicker not working when app targets Android 13 by [@​RodolfoGS](https://togithub.com/RodolfoGS) in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1973](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1973) #### New Contributors - [@​therealrinku](https://togithub.com/therealrinku) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1953](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1953) - [@​dipanjanpanja6](https://togithub.com/dipanjanpanja6) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1964](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1964) - [@​RodolfoGS](https://togithub.com/RodolfoGS) made their first contribution in [https://github.com/ivpusic/react-native-image-crop-picker/pull/1973](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1973) **Full Changelog**: ivpusic/react-native-image-crop-picker@v0.40.0...v0.40.1 ### [`v0.40.0`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.40.0) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.39.0...v0.40.0) ##### ios - Fix iPad crash ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1753](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1753)) - Add the way to customize iOS cropper toolbar ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1923](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1923)) ### [`v0.39.0`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.39.0) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.38.1...v0.39.0) ### ios - Add Finish Language ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1872](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1872)) - Add Danish Language ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1871](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1871)) ### android - Fix for openPicker not working when app targets Android 13 [#​1852](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1852) ### [`v0.38.1`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.38.1) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.38.0...v0.38.1) ### ios - Add Vietnamese language ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1835](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1835)) - fix: added PhotosUi That requeired for iOS ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1853](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1853)) ### [`v0.38.0`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.38.0) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.37.3...v0.38.0) #### ios - Add Norwegian strings ivpusic/react-native-image-crop-picker@a857dcb ### android - Add custom FileProvider implementation to avoid merging collision ivpusic/react-native-image-crop-picker@1870e4d - Fix android "Invalid image selected" issue ivpusic/react-native-image-crop-picker@248331c ### [`v0.37.3`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.37.3) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.37.2...v0.37.3) #### ios - fix view blinks on ios15 if enable cropping flag ([https://github.com/ivpusic/react-native-image-crop-picker/pull/1739](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1739)) ivpusic/react-native-image-crop-picker@356985a ### [`v0.37.2`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.37.2) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.37.1...v0.37.2) ### ios - Adding support for dark mode in limited permission help ([#​1680](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1680)) ivpusic/react-native-image-crop-picker@4a1bdbc ### [`v0.37.1`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.37.1) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.4...v0.37.1) #### ios - Adding messenger inspired iOS 14 limited permission info help in album controller ivpusic/react-native-image-crop-picker@cd26484 ### [`v0.36.4`](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.3...v0.36.4) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.3...v0.36.4) ### [`v0.36.3`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.36.3) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.2...v0.36.3) #### ios - Added romanian language (ios) ([#​1597](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1597)) ivpusic/react-native-image-crop-picker@cbe7f87 - fix(export): export named functions to match definitions ([#​1646](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1646)) ivpusic/react-native-image-crop-picker@540ecea #### android - started android 11 support ivpusic/react-native-image-crop-picker@2437d99 - remove write external storage permission only on android 11 ivpusic/react-native-image-crop-picker@f63a954 - Sometimes the length of the video cannot be retrieved. ivpusic/react-native-image-crop-picker@bbd8730 - Fix image compression OOM exception ([#​1627](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1627)) ivpusic/react-native-image-crop-picker@5333954 ### [`v0.36.2`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.36.2) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.1...v0.36.2) - (android) safer exif parsing ivpusic/react-native-image-crop-picker@16eb5e8 ### [`v0.36.1`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.36.1) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.36.0...v0.36.1) - (ios) Add heic format for determining MIME type ivpusic/react-native-image-crop-picker@a24af4c - (ios) turkish language strings added ivpusic/react-native-image-crop-picker@e311caa - (android) float variant of latitude/longitude exif data ivpusic/react-native-image-crop-picker@9d86ade ### [`v0.36.0`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.36.0) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.35.3...v0.36.0) #### Breaking changes - (ios/android) Make sure to return precise + platform-consistent permission error code [https://github.com/ivpusic/react-native-image-crop-picker/pull/1506](https://togithub.com/ivpusic/react-native-image-crop-picker/pull/1506) ### [`v0.35.3`](https://togithub.com/ivpusic/react-native-image-crop-picker/releases/tag/v0.35.3) [Compare Source](https://togithub.com/ivpusic/react-native-image-crop-picker/compare/v0.35.2...v0.35.3) - ios Fix video not loading from iCloud ([#​1515](https://togithub.com/ivpusic/react-native-image-crop-picker/issues/1515)) ivpusic/react-native-image-crop-picker@e3b12e9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
Hi, does the component work with newer Android SDK 34 and 35? or must we set it to 33? |
I'm using with 34. Read README:
|
In order to use v0.39.0, user must change SDK version to 33. If not, it throws error at
react-native-image-crop-picker/android/src/main/java/com/reactnative/ivpusic/imagepicker/PickerModule.java
Line 406 in 75955f0