Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return cropped image rectangle #458

Merged
merged 5 commits into from
Dec 7, 2017
Merged

Return cropped image rectangle #458

merged 5 commits into from
Dec 7, 2017

Conversation

ivan-magda
Copy link
Contributor

@ivan-magda ivan-magda commented Sep 21, 2017

Hey, @ivpusic! Please review.

Summary

  • Add cropRect response object
  • cropRect is an Object typeof CropRect
  • Use latest uCrop version 2.2.1 with the ability to get cropped image offset coordinates

Response example:

...
cropRect: {
   x: 268,
   y: 0,
   width: 393,
   height: 393
}
...

Closes: #457

@ivpusic
Copy link
Owner

ivpusic commented Sep 27, 2017

thanks a lot for implementing this feature. I was pretty busy to review it before. I see that there are now some merge conflicts. Do you have some time to take a look, fix merge conflicts, and then I will merge it. Thanks

@ivan-magda
Copy link
Contributor Author

@ivpusic, It's rebased.
You can review and merge if acceptable.

Thanks!

Use latest uCrop version.
Update Android installation instructions.
@ivan-magda
Copy link
Contributor Author

ping @ivpusic

1 similar comment
@ivan-magda
Copy link
Contributor Author

ping @ivpusic

@ivpusic ivpusic merged commit 5633a99 into ivpusic:master Dec 7, 2017
@ivpusic
Copy link
Owner

ivpusic commented Dec 7, 2017

thanks a lot! sorry for being late for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants