Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve specs for Ears class #37

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Improve specs for Ears class #37

merged 6 commits into from
Oct 26, 2023

Conversation

johannesluedke
Copy link
Contributor

@johannesluedke johannesluedke commented Oct 26, 2023

Issue: https://github.com/ivx/injixo/issues/28434

Preparation for the new Ears.setup_consumers interface

@johannesluedke johannesluedke self-assigned this Oct 26, 2023
@johannesluedke johannesluedke mentioned this pull request Oct 26, 2023
@johannesluedke johannesluedke changed the title Extend tests2 Improve specs for Ears class Oct 26, 2023
expect(Bunny).to have_received(:new).with(
rabbitmq_url,
connection_name: connection_name,
'amqp://guest:guest@localhost:5672',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be set in an Environment class somehow?

@johannesluedke johannesluedke merged commit c110b62 into main Oct 26, 2023
6 checks passed
@johannesluedke johannesluedke deleted the extend-tests2 branch October 26, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants