-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LinSpace to Raw_Ops for tf frontends #10871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Your PR looks good, just few changes I've requested on specific lines.
I'll merge your PR as soon as you make these changes.
Thanks 😄
@@ -607,3 +607,9 @@ def Elu(features, name=None): | |||
"float64", | |||
), | |||
} | |||
|
|||
|
|||
# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! thanks for your quick response. I will correct this.
|
||
# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow") | ||
@to_ivy_arrays_and_back | ||
def LinSpace(*, start, stop, num, name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These arguments are not keyword-only, you can remove *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for this, the test is now failing with an error as follows:
E TypeError: lin_space only takes keyword args (possible keys: ['start', 'stop', 'num', 'name']). Please pass these args as kwargs instead.
../../mambaforge/envs/ivy_dev/lib/python3.8/site-packages/tensorflow/python/util/tf_export.py:396: TypeError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a related error I found on the issue, if that helps (apologies if I'm being wrong somewhere).
Also, here's another (plausible) source to support my statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, You're right, I wasn't aware of that.
Thanks for clearing that up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the contribution. 👍
|
||
# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow") | ||
@to_ivy_arrays_and_back | ||
def LinSpace(*, start, stop, num, name=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, You're right, I wasn't aware of that.
Thanks for clearing that up 😄
Co-authored-by: sherry30 <sherrytst30@gmail.com>
Co-authored-by: sherry30 <sherrytst30@gmail.com>
Closes #10842