Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LinSpace to Raw_Ops for tf frontends #10871

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

sdk2k01
Copy link
Contributor

@sdk2k01 sdk2k01 commented Feb 23, 2023

Closes #10842

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Feb 23, 2023
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Your PR looks good, just few changes I've requested on specific lines.
I'll merge your PR as soon as you make these changes.

Thanks 😄

@@ -607,3 +607,9 @@ def Elu(features, name=None):
"float64",
),
}


# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! thanks for your quick response. I will correct this.


# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow")
@to_ivy_arrays_and_back
def LinSpace(*, start, stop, num, name=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These arguments are not keyword-only, you can remove *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for this, the test is now failing with an error as follows:

E       TypeError: lin_space only takes keyword args (possible keys: ['start', 'stop', 'num', 'name']). Please pass these args as kwargs instead.
../../mambaforge/envs/ivy_dev/lib/python3.8/site-packages/tensorflow/python/util/tf_export.py:396: TypeError

Copy link
Contributor Author

@sdk2k01 sdk2k01 Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a related error I found on the issue, if that helps (apologies if I'm being wrong somewhere).

Also, here's another (plausible) source to support my statement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, You're right, I wasn't aware of that.
Thanks for clearing that up 😄

@sdk2k01 sdk2k01 requested a review from sherry30 February 23, 2023 19:11
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks for the contribution. 👍


# @with_unsupported_dtypes({"2.9.1 and below": ()}, "tensorflow")
@to_ivy_arrays_and_back
def LinSpace(*, start, stop, num, name=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, You're right, I wasn't aware of that.
Thanks for clearing that up 😄

@sherry30 sherry30 merged commit 1ed6641 into ivy-llc:master Feb 24, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Co-authored-by: sherry30 <sherrytst30@gmail.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Co-authored-by: sherry30 <sherrytst30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinSpace
3 participants