Use image instead of dockerfile in dev container #11596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rishabh Kumar <rishabhkkumarsc1@gmail.com>
Co-authored by: pillarxyz <mail@aymanlafaz.com>, nassimberrada <Nassim>
Co-authored by MahmoudAshraf97 <hassouna97.ma@gmail.com>
Co-authored-by: Fotios Spyridakos <72918194+fspyridakos@users.noreply.github.com>
Co-authored by: SSahas <SSahas@users.noreply.github.com>, nassimberrada <Nassim>
…anged `bias_add` so that it also accepts "NHWC" type format in `data_format`
Co-authored-by: zaeemansari70 <zaeemansari70@gmail.com>
Resolve Issue in Intelligent Testing Syntax
* changes after force push * version unpinning --------- Co-authored-by: Rishabh Kumar <rishabhkkumarsc1@gmail.com>
* changes after force push * version unpinning * unpinned numpy --------- Co-authored-by: Rishabh Kumar <rishabhkkumarsc1@gmail.com>
CatB1t
suggested changes
Mar 3, 2023
| git submodule update --init --recursive | ||
|
|
||
| python3 -m pip install --user -e . |
There was a problem hiding this comment.
Quick note: this is used here to install Ivy as a local package, we should keep it.
|
Looks like multiple dev containers are not supported yet microsoft/vscode-remote-release#1165. I can add the config jsons, but you still need to copy the needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allows user to use pre-built docker image to build the vs-code dev-containers instead of building the ivy image locally. Also, added the pre-commit step for git workflow inside the container.
Before merging:
Suggestion: We should move the
.devcontainerfolder to.gitignoreallowing user to tailor the development environment according to their requirements without requiring to stash every time they pull.