Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(paddle frontend): add index_sample function #26612

Closed
wants to merge 0 commits into from
Closed

feat(paddle frontend): add index_sample function #26612

wants to merge 0 commits into from

Conversation

ksbharaj
Copy link

@ksbharaj ksbharaj commented Oct 4, 2023

PR Description

Added index_sample as per paddle documentation.

Related Issue

Close #26495

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

github-actions[bot]
github-actions bot reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@ksbharaj ksbharaj changed the title Ksb 14 paddle frontend: add index_sample() Oct 4, 2023
@ksbharaj ksbharaj changed the title paddle frontend: add index_sample() feat(paddle frontend): add index_sample function Oct 4, 2023
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@KareemMAX
Copy link
Contributor

Hi @ksbharaj , seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

@ksbharaj ksbharaj closed this Oct 7, 2023
@ksbharaj
Copy link
Author

ksbharaj commented Oct 7, 2023

Hi @ksbharaj , seems like you have changed docs/demos which you might have done by mistake. Can you revert that change because we can't merge with that change in place?

Thanks, @KareemMAX. I have pushed a corrected version now. Please see #26756.
Thank you once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

@KareemMAX KareemMAX Awaiting requested review from KareemMAX

Assignees

@YushaArif99 YushaArif99

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index_sample
4 participants
@ksbharaj @KareemMAX @YushaArif99 @ivy-leaves