Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Paddle signal module with istft function #27281

Closed
wants to merge 1 commit into from

Conversation

niixxaaa
Copy link
Contributor

@niixxaaa niixxaaa commented Nov 14, 2023

Fixes #27280

@vedpatwardhan @NripeshN, istft is not implemented in ivy backend. Could we maybe implement it?
FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_signal.py::test_paddle_istft[cpu-numpy-False-False] - AttributeError: module 'ivy.functional.backends.numpy' has no attribute 'istft' FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_signal.py::test_paddle_istft[cpu-jax-False-False] - AttributeError: module 'ivy.functional.backends.jax' has no attribute 'istft' FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_signal.py::test_paddle_istft[cpu-tensorflow-False-False] - hypothesis.errors.InvalidArgument: Cannot sample from a length-zero sequence. FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_signal.py::test_paddle_istft[cpu-torch-False-False] - AttributeError: module 'ivy.functional.backends.torch' has no attribute 'istft' FAILED ivy_tests/test_ivy/test_frontends/test_paddle/test_signal.py::test_paddle_istft[cpu-paddle-False-False] - AttributeError: module 'ivy.functional.backends.paddle' has no attribute 'istft'

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Nov 14, 2023
@vedpatwardhan
Copy link
Contributor

Hey @niixxaaa, thanks for the suggestion! However, we're currently more focused on fixing and optimizing existing functions which are used in popular models than adding new ones, but we can certainly add it in the future 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

istft
5 participants