Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issues with tile function in Ivy Functional API #28402

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jacksondm33
Copy link
Contributor

@jacksondm33 jacksondm33 commented Feb 22, 2024

PR Description

Fixes multiple issues related to the tile function in the Ivy Functional API:

  • expands test cases in the Ivy Functional API test for tile
  • fixes edge case handling in the Paddle and TensorFlow backend functions for tile
  • fixes unbounded array size in PyTorch Frontend API test for Tensor.repeat

Related Issue

Closes #28264
Closes #28265
Closes #28403
Closes #28322

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@jacksondm33 jacksondm33 changed the title Fix tile issues fix: fix issues with tile function in Ivy Functional API Feb 22, 2024
@ivy-leaves ivy-leaves added Paddle Paddle Backend Ivy Functional API PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Feb 22, 2024
@jacksondm33 jacksondm33 marked this pull request as draft February 23, 2024 00:54
@jacksondm33 jacksondm33 marked this pull request as ready for review February 23, 2024 04:29
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jacksondm33
Thanks for the PR
There are countless failures based on this PR that you may check under logs at https://github.com/unifyai/ivy/actions/runs/8068356045/job/22049814695?pr=28402
Could it be due to changes to astype which is a very fundamental function or due to changes in mean?

@jacksondm33
Copy link
Contributor Author

@Ishticode Okay, I'll try to see if I can find any failing tests caused by my changes. However, the tests system decided to run a lot more tests than usual for a PR, so I'm guessing that many of these tests are already failing on the latest commit without my changes.

@jacksondm33 jacksondm33 force-pushed the fix_tile_issues branch 7 times, most recently from e642bff to 4f3f531 Compare April 4, 2024 06:30
@jacksondm33 jacksondm33 force-pushed the fix_tile_issues branch 4 times, most recently from 5e691ef to 0b9564d Compare April 11, 2024 03:55
@ivy-leaves ivy-leaves added the Ivy API Experimental Run CI for testing API experimental/New feature or request label Apr 11, 2024
@jacksondm33
Copy link
Contributor Author

I modified the intelligent-tests-pr workflow to also run the determined tests on the main branch and only note failures that passed when run on main. While this doesn't guarantee that my changes don't introduce new failures to already failing tests, it does show that it can't find any currently passing tests that fail with my changes. I ran two workflows, one of which ran the usual 25 examples (redis database + generated) and another that ran 100 deterministically-generated examples for each test. The only noted failures were recursion errors that seemed to have caused the corresponding runs on main to be skipped (?).
Action #41699
Action #41700

@jacksondm33 jacksondm33 requested a review from Ishticode April 12, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API Paddle Paddle Backend PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
4 participants