New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credits detection functionality #93

Merged

iwalton3 merged 1 commit into iwalton3:master from Brett824:add-credit-skip

Jun 1, 2023

Contributor

Brett824 commented Jun 1, 2023

Suggested in #86

Tried to avoid duplicate code where ever possible, but I didn't get too clever because I wanted to just get the functionality working

Some notes:

Factored the intro checking logic in PlayerManager.update to PlayerManager.check_intro_or_credits just for visual clarity
Similarly factored some common logic into new PlayerManager.skip_marker function to implement PlayerManager.skip_credits
Added credits skip functionality wherever intro skip existed (seeking, media keys, etc)
Added two new options for credit skip prompt and always skip credits + added those options to the readme


add credits skipping

d07f17f

iwalton3 approved these changes

View reviewed changes

iwalton3 merged commit a154586 into iwalton3:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment