Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes backslashes to forward slashes in relative path before upload… #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joeenzminger
Copy link

…ing.

I've run into an issue where backslashes (using vinyl-s3 on windows) don't display correctly the s3 interface (path is treated as a single file rather than a directory hierarchy).

I know internally S3 doesn't care, but this fix does make it easier to debug and visualize uploads to S3 using the AWS console.

@joeenzminger
Copy link
Author

A little more info on this - on windows, file.relative returns backslashed paths, even though cwd, base, and path have forward slashes. S3 expects forward slash path names in the key. Backslashes are treated as string literals. Since vinyl-s3 uses file.relative unmodified, there isn't a way modify the key using a prior pipeline plugin (like gulp-slash).

WillBartee pushed a commit to WillBartee/vinyl-s3 that referenced this pull request Feb 27, 2017
changes backslashes to forward slashes in relative path before upload

See: izaakschroeder#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant