Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ecto options in insert and insert! functions #102

Merged
merged 1 commit into from
Aug 30, 2020
Merged

add support for ecto options in insert and insert! functions #102

merged 1 commit into from
Aug 30, 2020

Conversation

hdtafur
Copy link
Contributor

@hdtafur hdtafur commented Aug 27, 2020

Pass through any ecto options to insert and insert!. This does not (yet) thread the options through toupdate and update!. If it is acceptable as is, we can add the option to updates on a new pull request 😎

This might address #32

Signed-off-by: Erik Hanson <erik@geometer.io>
@izelnakri
Copy link
Owner

very nice PR, thank you! Might be also good to add this to other ecto actions as well such as update and insert, although it would be less useful.

@izelnakri izelnakri merged commit ddc7f91 into izelnakri:master Aug 30, 2020
mayel pushed a commit to bonfire-networks/paper_trail that referenced this pull request Jun 26, 2023
…ri#102)

Signed-off-by: Erik Hanson <erik@geometer.io>

Co-authored-by: Harold Tafur <harold@geometer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants