Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print protoc error messages #136

Merged
merged 3 commits into from
Dec 24, 2018
Merged

Conversation

izumin5210
Copy link
Owner

WHY

WHAT

REF

pkg/cli/ui.go Outdated Show resolved Hide resolved
@izumin5210
Copy link
Owner Author

image

@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #136 into master will increase coverage by 0.17%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   61.49%   61.67%   +0.17%     
==========================================
  Files          39       39              
  Lines        1322     1328       +6     
==========================================
+ Hits          813      819       +6     
  Misses        452      452              
  Partials       57       57
Impacted Files Coverage Δ
pkg/protoc/wrapper.go 67.27% <0%> (ø) ⬆️
pkg/cli/nop_ui.go 0% <0%> (ø) ⬆️
pkg/cli/ui.go 90.9% <100%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb13803...ec9b42c. Read the comment docs.

@izumin5210 izumin5210 merged commit 0c6f060 into master Dec 24, 2018
@izumin5210 izumin5210 deleted the izumin5210/protoc-err-message branch December 24, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants