fix: use get packet receipt for has query receipt (icon-project#163)

Co-authored-by: izyak <izyak@mail.co>
izyak · Sep 7, 2023 · ac32650 · ac32650
1 parent b3370a5
commit ac32650
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/relayer/chains/icon/methods.go b/relayer/chains/icon/methods.go
@@ -23,7 +23,6 @@ const (
 
 	MethodGetPacketCommitment                = "getPacketCommitment"
 	MethodGetPacketAcknowledgementCommitment = "getPacketAcknowledgementCommitment"
-	MethodHasPacketReceipt                   = "hasPacketReceipt"
 	MethodGetPacketReceipt                   = "getPacketReceipt"
 	MethodGetNextSequenceReceive             = "getNextSequenceReceive"
 	MethodGetNextSequenceSend                = "getNextSequenceSend"

diff --git a/relayer/chains/icon/query.go b/relayer/chains/icon/query.go
@@ -764,14 +764,14 @@ func (icp *IconProvider) QueryPacketAcknowledgement(ctx context.Context, height
 }
 
 func (icp *IconProvider) QueryPacketReceipt(ctx context.Context, height int64, channelid, portid string, seq uint64) (recRes *chantypes.QueryPacketReceiptResponse, err error) {
-	callParam := icp.prepareCallParams(MethodHasPacketReceipt, map[string]interface{}{
+	callParam := icp.prepareCallParams(MethodGetPacketReceipt, map[string]interface{}{
 		"portId":    portid,
 		"channelId": channelid,
 		"sequence":  types.NewHexInt(int64(seq)),
 	})
 	var packetReceiptHexByte types.HexInt
 	if err := icp.client.Call(callParam, &packetReceiptHexByte); err != nil {
-		return nil, err
+		packetReceiptHexByte = types.NewHexInt(0)
 	}
 	packetReceipt, err := packetReceiptHexByte.Value()
 	if err != nil {

diff --git a/relayer/chains/icon/tx.go b/relayer/chains/icon/tx.go
@@ -694,7 +694,8 @@ func (icp *IconProvider) SendMessagesToMempool(
 		if msg != nil {
 			err := icp.SendIconTransaction(ctx, msg, asyncCtx, asyncCallback)
 			if err != nil {
-				return err
+				icp.log.Warn("Send Icon Transaction Error", zap.String("method", msg.Type()), zap.Error(err))
+				continue
 			}
 		}
 	}