Fundamental issue in random-beans-validation

[devoto13]

I found fundamental problem in random-beans-validation implementation. Currently every randomizer created by the package will generate same value every time (or almost every time, see below).

Let's for example look into SizeAnnotationHandler.

Every time randomizer is looked up for field annotated with @Size it will create new instance of CharacterRandomizer providing it with same seed and therefore randomizer will generate same value every time. Or almost every time, because randomizer for string length is not using seed (but it should). Other annotation handlers have same issue, except those generating constant values (for obvious reasons).

Ideal solution would be to somehow cache randomizers created for the field from annotation. But I'm not good with Java, so not sure how feasible/doable it is.

[fmbenhassine]

Hi @devoto13

Thank you for reporting this. We have deployed a fix in 3.6.0-SNAPSHOT.

Could you please give it a try and tell us if this is ok for you?

Kind regards
Mahmoud

[devoto13]

@benas @PascalSchumacher Thank you, guys, for a quick fix!

I tried it and it works very well. Closing the issue.

[PascalSchumacher]

Thanks reporting the issue and for the feedback on the fix. 👍 😃