Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TODO in reflection utils #253

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Fix TODO in reflection utils #253

merged 1 commit into from
Apr 28, 2017

Conversation

VanOvermeire
Copy link

This might solve the TODO in reflection utils, by creating an enum that wraps around the stuff you need in the getWrapperType enum.

Looks a lot cleaner at any rate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 90.856% when pulling 030f253 on VanOvermeire:feature-solve-reflectionutils-todo into 0188897 on benas:master.

@fmbenhassine
Copy link
Member

Great! it's cleaner at all levels 👍
Thank you very much.

@fmbenhassine fmbenhassine merged commit e7947b4 into j-easy:master Apr 28, 2017
@fmbenhassine fmbenhassine added this to the 3.7.0 milestone Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@VanOvermeire @coveralls @fmbenhassine