Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add randomizers for MAC, IPv4 and IPv6 addresses #358

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Add randomizers for MAC, IPv4 and IPv6 addresses #358

merged 3 commits into from
Oct 25, 2019

Conversation

reitzmichnicht
Copy link
Contributor

Add some common randomizers provided by JavaFaker.

Also changed implementation of FakerBasedRandomizer so it can be extended from outside.

@reitzmichnicht
Âdd randomizers for Mac, IPv4 and IPv6.
8ff58ac 
Including tests
@reitzmichnicht
Changed FakerBasedRandomizer so it is extendable.
2582be7 
Now everyone can add new Randomizers based on this implementation.
@fmbenhassine
Copy link
Member

fmbenhassine commented Jun 8, 2019 •
edited
Loading

Nice additions 👍

Also changed implementation of FakerBasedRandomizer so it can be extended from outside.

We need to change the visibility of the field Faker faker in FakerBasedRandomizer to protected as well, to be able to use it in sub classes defined outside the package. Do you agree?

@reitzmichnicht
Copy link
Contributor Author

You are right, I updated the pull request

@fmbenhassine fmbenhassine merged commit 377f157 into j-easy:master Oct 25, 2019
@fmbenhassine fmbenhassine added this to the 4.1.0 milestone Oct 25, 2019
@reitzmichnicht reitzmichnicht deleted the randomizer branch December 16, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@reitzmichnicht @fmbenhassine