Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_transit_gateway_peering_attachment: Get acceptance tests pa… #4

Merged

Conversation

j-nix
Copy link
Owner

@j-nix j-nix commented Jan 10, 2020

…ssing.

Implement @ewbankkit's work for transit gateway peering:

hashicorp#11162 (comment)

  • The resources were left dangling because the Config value was not set on the import test step as required for cross-region acceptance tests and documented in the Contributing guide
  • The test case was actually failing because of a resource name mismatch (.example vs. .test)
  • Because of the dangling resources I ran the test sweeper and add it as a dependency to the aws_ec2_transit_gateway test sweeper
  • I made peer_account_id optional (defaults to current account ID) as for VPC peering connections and also made all the other attributes (except tags) ForceNew: true which means that the Update method only deals with changes to tags
  • Tidied up various other things on the way

@Omarimcblack Omarimcblack merged commit 4e48f9f into j-nix:add_transit_gw_peering Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants