makeAbsolute: remove slash trim as it can break some urls

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
j0k3r · Oct 29, 2021 · aeee833 · aeee833
1 parent 75c8251
commit aeee833
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/Graby.php b/src/Graby.php
@@ -779,8 +779,6 @@ private function getSinglePage($html, $url)
      */
     private function makeAbsolute($base, \DOMElement $elem)
     {
-        $base = trim($base, '/');
-
         foreach (['a' => 'href', 'img' => 'src', 'iframe' => 'src'] as $tag => $attr) {
             $elems = $elem->getElementsByTagName($tag);
 

diff --git a/tests/GrabyTest.php b/tests/GrabyTest.php
@@ -823,6 +823,7 @@ public function dataForMakeAbsolute(): array
             ['http://example.org', '<img src="//domain.com/lol.jpg">test</img>', 'src', 'http://domain.com/lol.jpg'],
             ['http://example.org', '<img src=" /path/to/image.jpg" />', 'src', 'http://example.org/path/to/image.jpg'],
             ['http://example.org', '<a href="/lol">test</a>', 'src', ''],
+            ['http://example.org/folder/', '<img src="visual.jpg" />', 'src', 'http://example.org/folder/visual.jpg'],
         ];
     }