Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of name from JsonLd as title #166

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Use of name from JsonLd as title #166

merged 1 commit into from
Oct 4, 2018

Conversation

Simounet
Copy link
Contributor

@Simounet Simounet commented Oct 4, 2018

We can use the name from the JsonLd (https://schema.org/VideoObject). Not sure about headline pertinence as a title.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.361% when pulling dc01726 on Simounet:feature/name-from-json-ld into c31cb67 on j0k3r:master.

@j0k3r
Copy link
Owner

j0k3r commented Oct 4, 2018

Question is: what's the priority between headline & name? Which one should override the other one?

@Simounet
Copy link
Contributor Author

Simounet commented Oct 4, 2018 •
edited
Loading

As far I understood, name is more important than headline.

@j0k3r j0k3r merged commit f419f8e into j0k3r:master Oct 4, 2018
@j0k3r
Copy link
Owner

j0k3r commented Oct 4, 2018

👍

@Simounet Simounet deleted the feature/name-from-json-ld branch October 4, 2018 13:39
@techexo techexo mentioned this pull request Jan 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simounet @coveralls @j0k3r