Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild siteconfig if host for singlepage is not the same than the so… #246

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

Kdecherf
Copy link
Collaborator

Consider a single_page_link directive on twitter.com that follows any
link found in a tweet. Here is an example with the following tweet:

https://twitter.com/Cloudflare/status/1341353044504694787

This eventually leads to the following page:

https://blog.cloudflare.com/beat-an-acoustics-inspired-ddos-attack/

Until now, Graby was incorrectly sending to cloudflare.com
http headers defined for twitter.com.

Copy link
Owner

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!
Could you fix PHPStan & add some tests?

@Kdecherf Kdecherf force-pushed the singlepage-rebuild-site-config branch from a080ff3 to 05eeb42 Compare January 17, 2021 18:19
@coveralls
Copy link

coveralls commented Jan 17, 2021

Coverage Status

Coverage increased (+0.03%) to 96.482% when pulling 898a6be on Kdecherf:singlepage-rebuild-site-config into 1c581bb on j0k3r:master.

…urce

Consider a `single_page_link` directive on twitter.com that follows any
link found in a tweet. Here is an example with the following tweet:

  https://twitter.com/Cloudflare/status/1341353044504694787

This eventually leads to the following page:

  https://blog.cloudflare.com/beat-an-acoustics-inspired-ddos-attack/

Until now, Graby was incorrectly sending to cloudflare.com
http headers defined for twitter.com.

Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
@Kdecherf Kdecherf force-pushed the singlepage-rebuild-site-config branch from 4fe37ad to 898a6be Compare January 17, 2021 19:15
@Kdecherf Kdecherf requested a review from j0k3r January 17, 2021 19:17
@Kdecherf Kdecherf force-pushed the singlepage-rebuild-site-config branch from 443bb9c to 898a6be Compare January 19, 2021 22:56
@Kdecherf Kdecherf requested a review from j0k3r January 19, 2021 23:06
@j0k3r j0k3r merged commit e115409 into j0k3r:master Jan 20, 2021
@Kdecherf Kdecherf deleted the singlepage-rebuild-site-config branch January 20, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants