Graby: Return object instead of an array #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
commented
Mar 30, 2023
| */ | ||
| final class Content | ||
| { | ||
| private int $status; |
There was a problem hiding this comment.
Maybe instead of HTTP properties, we could just store PSR-7 response object.
There was a problem hiding this comment.
As far as I remember we've added the status to be able to retrieve it in wallabag (same as for headers).
So maybe we can ditch both and keep one response or httpResponse?
There was a problem hiding this comment.
Yes, though I would want to return that with Graby\Extractor\HttpClient::fetch(). And we would still need some mechanism to pass the effective URL. I guess we can decide on that later.
jtojnar
force-pushed
the
content-object
branch
2 times, most recently
from
0c7087f to
a5864a4
Compare
jtojnar
commented
Mar 30, 2023
jtojnar
force-pushed
the
content-object
branch
3 times, most recently
from
1384824 to
cbe698a
Compare
j0k3r
reviewed
Mar 30, 2023
jtojnar
force-pushed
the
content-object
branch
8 times, most recently
from
61c1b13 to
23e2cfa
Compare
string|false is annoying.
Use `array<string>` instead of `array<string|false>|null`.
This will allow static analysis tools to work better and make Graby more usable in IDEs.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.