Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a rejected promise instead of throwing #10

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 14, 2023

Otherwise it will mess up async clients.

While at it, fix developer tools (the old versions do not work on PHP 8 any more).

@j0k3r
Copy link
Owner

j0k3r commented Apr 14, 2023

@jtojnar I've updated the CI, thanks for updating the code base 👍🏼
As we drop PHP < 7.4, I'll release 3.0 for it (or you might have more stuff to change?)

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 14, 2023

This looks nice for now. Cleaning up the types would be nice, opened #12. Another thing we could do is replace the obsolete php-http libraries with psr ones but that apparently requires psr/http-factory, which is currently incompatible with guzzlehttp/psr7.

@j0k3r j0k3r merged commit 4549a84 into j0k3r:master Apr 17, 2023
@jtojnar jtojnar deleted the promising branch April 17, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants