Revert "Add Accept: */* header"

[j0k3r]

We got some many side effects when declaring headers that way. Even if by reading the code, everything should work as normal.
Like in j0k3r/graby#162.
But also, paywall stuff in wallabag doesn't work anymore because some headers are missing after few requests.

It was really hard to debug and it's still hard to describe a real scenario to allow someone to fix the problem.
As a conclusion, reverting the PR is a better solution at the moment.

Reverts #4

[nijel]

The problem might be in setting headers elsewhere in the code as caling curl_setopt($this->curlHandle, CURLOPT_HTTPHEADER,...) overrides previously defined headers.

The else branch for getPinDns() did not set the headers before and I probably it's the usually used one. The proper fix probably would be to make SafeCurl::execute accept additional headers as a parameter and callers would use this interface exclusively to set the headers without manually touching them.

Anyway if this patch broke things, the getPinDns() branch in SafeCurl::excecute is broken in same way, it's probably not that visible.

[j0k3r]

You might be right.
I'm not using the pinDns option in any project.

I guess the problem will be gone when graby will switch to httplug (and use https://github.com/j0k3r/httplug-ssrf-plugin instead of SafeCurl)

In the meantime, sorry to revert your PR as you might not be able to save content from (at least) marigold.cz.

[nijel]

Okay, I've tried to address my problem at higher level, what is probably more appropriate: wallabag/wallabag#3751