Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line_height config option #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add line_height config option #167

wants to merge 1 commit into from

Conversation

ataractic
Copy link

@ataractic ataractic commented Aug 11, 2024

Closes #166

Makes the line height configurable in pixels instead of being hard-coded to font_size * 1.2.

Thought of other options as well:

  • Add option for automatic text height based on the font size (like before this pull request)
  • Add option for separately setting the spacing between the results and the query line

@j0ru
Copy link
Owner

j0ru commented Aug 31, 2024

Hey, thanks for the pull request! Unfortunately I'm currently in the middle of moving countries, but I'll review it as soon as I have a stable network connection and a minute to think about it ;)

@j0ru
Copy link
Owner

j0ru commented Oct 13, 2024

Hm, I'm not a fan of changing a relative value into an absolute one, because that would impact everyone that uses a non-default font size. If you'd make the value optional and default back to the original behavior of multiplying the font size, I'd be okay with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add line height config option
2 participants