Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write for PSR, PHP 7.1+? #129

Closed
tag opened this issue Mar 16, 2017 · 5 comments
Closed

Re-write for PSR, PHP 7.1+? #129

tag opened this issue Mar 16, 2017 · 5 comments

Comments

@tag
Copy link
Contributor

tag commented Mar 16, 2017

@treffynnon , how would you feel about opening a branch for a 2.0 version with the following goals?

  • PHP 7.1+ only
  • PSR-1, PSR-2 (code style, naming)
  • PSR-4 (name spacing, auto-loading)
  • (possibly; I haven't looked into it) PSR-16 (simple caching)
  • Updating documentation & PHPDoc blocks
  • EDIT: PSR-3 (logging)
  • Consistent with the goals of Paris/Idiorm, not adding new features, EXCEPT IDE helpers (e.g., Allowing IDE autocomplete #128)

Link to PSR standards.

I feel like Paris is beginning to show its age, and it's time to have a version that drops support for 5.2 (and some of the workarounds necessary to support it) and embraces namespacing. I'm okay with this being a backward-compatible break (which would be necessary for PSRs 2 & 4)

I'll have some time in May to work on this, but wanted to get your support before spending time on it.

@treffynnon
Copy link
Collaborator

This has been brought up a few times and my feeling is that it's outside the scope of Paris. Additionally, with Eloquent ORM already fulfilling most of those criteria and looking a lot like Paris and Idiorm in terms of API I am not sure the effort is worthwhile. What would it be providing that Eloquent doesn't already? How would it be more useful to implementers?

@tag
Copy link
Contributor Author

tag commented Mar 17, 2017

I realize it's been brought up several times—which is partly why I did so again. This suggests to me there is some interest in carrying Paris forward to PHP 7.1. I'll have some time this summer to work on it, and getting your buy-in would partially dictate whether/how much time I spend on it.

For me, I typically only do small projects any more, for which Paris is ideal. Plus, I know it and am comfortable with it. I'd still like to see it updated, and my suspicion is others would as well.

The point of Paris isn't to compete with Eloquent. As you've said many times, it's an 80/20 solution, and I'm content with that. But when I need to dig into the code to figure something out, it would be easier to have the code in use a standard similar to other libraries.

Are you suggesting that implementers should not use Paris in the future, and transition to Eloquent instead?

@treffynnon
Copy link
Collaborator

But when I need to dig into the code to figure something out, it would be
easier to have the code in use a standard similar to other libraries.

This is what, I feel, Eloquent already provides. If you're starting a new
project and desire these features then I'd recommend using Eloquent as I've
done in the past.

Are you suggesting that implementers should not use Paris in the future,
and transition to Eloquent instead?

Well that is a choice for individuals to make themselves.

That said I have used Eloquent successfully for a number of projects as a
replacement for Paris. It suited the small and simple need perfectly. Given
its origins this makes sense.

I have not used Idiorm or Paris in a new project for a few years - the
project is still maintained for those users who have it out in the wild or
still desire to use it (there are still many projects using it at my
previous place of work for instance).


Jamie and I took the decision to freeze feature development a while ago now
and I still think that was the right choice. There is a pretty good upgrade
path for those that choose to (Eloquent) and maintenance for those
currently using or deciding to use Paris.


All that said, you can, of course, fork and start a new project - the
licence is open and permissible. I just don't think that Paris is the right
place for this work going forward.

Thank you for your contributions to Paris and Idiorm - I hope you can see
the reasoning behind the decision.

@richp10
Copy link

richp10 commented Mar 31, 2017

I really like paris / idiorm but had all sorts of problems when switching to PHP7

There is already a good fork, which is working well for me:
https://github.com/voku/paris

It would be a shame if idiorm dwindled because of lack of namespacing and I wonder if there might be some way of voku being an 'official' php7 / namespaced fork?

@treffynnon
Copy link
Collaborator

treffynnon commented Mar 31, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants