Fixed #105 - Join table name not generated properly

[n-at-han-k]

There was an issue with the has_many_through method. When you
passed it a model to associate with that had a namespace.
e.g. $post->has_many_through('\Blog\Models\Tag');

The error was that it wasn't correctly creating the table
name for the join.
e.g. post_tag was instead post_blog_models_tag
Thus results weren't being fetched.

Basically it was performing an algorithm to extract the class name from the namespace on one of the classes but not the other. So Paris would end up requesting a table like "post_namespace_namespace_tag" instead of "post_tag".

Fixes #105

[n-at-han-k]

The Travis CI build fails for 5.2 due to the unit test using namespaces.
Namespaces are needed in the tests because the bug only becomes apparent when using them in your project.
The actual fix doesn't break anything.

[treffynnon]

Thanks for the pull request. To get your tests to pass you need to change
the name of your phpunit file. I've created a rule so that if you append
Test53.php instead of just Test.php then it won't be run on anything less
than PHP 5.3. Please see phpunit.xml for where this rule is set. You'll
notice the ModelPrefixingTest53.php test file uses this format for example
as well.
On 19 Feb 2015 22:57, "Nathan Kidd" notifications@github.com wrote:

The Travis CI build fails for 5.2 due to the unit test using namespaces.
Namespaces are needed in the tests because bug only becomes apparent when
using them in your project.
The actual fix doesn't break anything.

—
Reply to this email directly or view it on GitHub
#109 (comment).

[n-at-han-k]

Sorted it. Tests now pass.

[richp10]

I have run into this same problem - is there any chance this can be merged into master?

[treffynnon]

There is a chance. I've just got to get around to it. Unfortunately I've started another job and various other life stuff is still consuming my time. It's certainly on my to do list.

[treffynnon]

Merged into develop. Thanks.