Skip to content

AnimationMask is not dispatched to internal actions #1199

@Ali-RS

Description

@Ali-RS

Here in this line

where the mask is set to running action in the layer, it does not dispatch the mask to child actions as well.
Actually, we can set a mask to each child action separately when we create it but my understanding is the mask is supposed to be provided directly from AnimComposer to the whole action including the chained actions. This means that internal actions can not have a different mask.

If my assumption is true then following method on 'Action'

public void setMask(AnimationMask mask) {
this.mask = mask;
}

should be changed to this

this.mask = mask;
for(Action action : actions) {
     action.setMask(mask);
}

I can make a PR if everyone is agree with this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething that is supposed to work, but doesn't. More severe than a "defect".

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions