-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
bugSomething that is supposed to work, but doesn't. More severe than a "defect".Something that is supposed to work, but doesn't. More severe than a "defect".
Milestone
Description
Here in this line
| currentAction.setMask(layer.mask); |
where the mask is set to running action in the layer, it does not dispatch the mask to child actions as well.
Actually, we can set a mask to each child action separately when we create it but my understanding is the mask is supposed to be provided directly from AnimComposer to the whole action including the chained actions. This means that internal actions can not have a different mask.
If my assumption is true then following method on 'Action'
jmonkeyengine/jme3-core/src/main/java/com/jme3/anim/tween/action/Action.java
Lines 54 to 56 in b1db497
| public void setMask(AnimationMask mask) { | |
| this.mask = mask; | |
| } |
should be changed to this
this.mask = mask;
for(Action action : actions) {
action.setMask(mask);
}
I can make a PR if everyone is agree with this change.
oxplay2 and yaRnMcDonuts
Metadata
Metadata
Assignees
Labels
bugSomething that is supposed to work, but doesn't. More severe than a "defect".Something that is supposed to work, but doesn't. More severe than a "defect".