Common/MatDefs/Light/PBRLighting.vert exception in 3.3.0-beta1(after switch from alpha5)

[oxplay2]

Hi, after switch to new beta1 of 3.3 seems like im getting new issue. i dont think its related to my changes, because i dont trully made any to that Test.

Im using shape keys to manipulate morph shapes of Character models. So its related probably only for morph shapes models.

gru 22, 2019 3:08:39 PM com.jme3.app.LegacyApplication handleError
SEVERE: Uncaught exception thrown in Thread[main,5,main]
com.jme3.renderer.RendererException: compile error in: ShaderSource[name=Common/MatDefs/Light/PBRLighting.vert, defines, type=Vertex, language=GLSL150]
0(423) : error C1111: non-lvalue actual parameter #2 cannot be out parameter ("norm.27")

	at com.jme3.renderer.opengl.GLRenderer.updateShaderSourceData(GLRenderer.java:1476)
	at com.jme3.renderer.opengl.GLRenderer.updateShaderData(GLRenderer.java:1503)
	at com.jme3.renderer.opengl.GLRenderer.setShader(GLRenderer.java:1567)
	at com.jme3.material.logic.SinglePassAndImageBasedLightingLogic.render(SinglePassAndImageBasedLightingLogic.java:259)
	at com.jme3.material.Technique.render(Technique.java:166)
	at com.jme3.material.Material.render(Material.java:1026)
	at com.jme3.renderer.RenderManager.renderGeometry(RenderManager.java:614)
	at com.jme3.renderer.queue.RenderQueue.renderGeometryList(RenderQueue.java:266)
	at com.jme3.renderer.queue.RenderQueue.renderQueue(RenderQueue.java:305)
	at com.jme3.renderer.RenderManager.renderViewPortQueues(RenderManager.java:877)
	at com.jme3.renderer.RenderManager.flushQueue(RenderManager.java:779)
	at com.jme3.renderer.RenderManager.renderViewPort(RenderManager.java:1108)
	at com.jme3.renderer.RenderManager.render(RenderManager.java:1158)
	at com.jme3.app.SimpleApplication.update(SimpleApplication.java:272)
	at com.jme3.system.lwjgl.LwjglWindow.runLoop(LwjglWindow.java:503)
	at com.jme3.system.lwjgl.LwjglWindow.run(LwjglWindow.java:585)
	at com.jme3.system.lwjgl.LwjglWindow.create(LwjglWindow.java:427)
	at com.jme3.app.LegacyApplication.start(LegacyApplication.java:463)
	at com.jme3.app.LegacyApplication.start(LegacyApplication.java:424)
	at com.jme3.app.SimpleApplication.start(SimpleApplication.java:127)

This refer to:

421	    void Morph_Compute(inout vec4 pos){
422	        #if (NUM_TARGETS_BUFFERS == 2)
423	            Morph_Compute_Pos_Norm(pos,vec3(0.0));
424	            return;
425	        #elif (NUM_TARGETS_BUFFERS == 3)
426	            Morph_Compute_Pos_Norm_Tan(pos, vec3(0.0), vec3(0.0));
427	            return;
428	        #endif
429	        Morph_Compute_Pos(pos);
430	    }
431	

below line is problematic:

423 Morph_Compute_Pos_Norm(pos,vec3(0.0));

[oxplay2]

last changes for it were made in:

30df2f1

topic about change:

https://hub.jmonkeyengine.org/t/fixed-morph-anim-shader-compilation-in-android/42522

[riccardobl]

mhh... the error says it
non-lvalue actual parameter #2 cannot be out parameter ("norm.27")
-->
void Morph_Compute_Pos_Norm(inout vec4 pos, inout vec3 norm)

Morph_Compute_Pos_Norm(pos,vec3(0.0));

When you removed the dummy variables you must have broken it in some implementations

[oxplay2]

"When you removed" - i dont, its beta1 code.

seems like from his fix(30df2f1), it should contain just:

if (gl2 != null && !(gl instanceof GLES_30)) {

and

float sum = 0.0;

without removing dummy variables then?

because it was android issue fix, so i dont really know what "break" on android exactly since i dont use android.

[riccardobl]

Oh yes, sorry, i mean @joliver82 , not you.
The change regarding these two lines

vec3 dummy_norm = vec3(0.0);
vec3 dummy_tan = vec3(0.0);

in the commit you linked, should be revered.
Then it should work fine.

[Ali-RS]

I guess there was an issue with those dummy vectors on Android that @joliver82 removed them. See #635 (comment)

[riccardobl]

Mh, ok. But they don't need to be global.

[riccardobl]

Try this patch riccardobl@817f4b3

I didn't test it, but it should be ok.

[Ali-RS]

Tried your patch, working fine for me.

[oxplay2]

thanks Riccardo and Ali :) just need put as fix

[Ali-RS]

@riccardobl any chance for a PR?

[joliver82]

Sorry for breaking this, I missed the inout in those parameters 🤦‍♂️ but it worked properly in both my mobile and in my desktop. Thanks @riccardobl for addressing it ;)

[riccardobl]

Don't worry. It seems a compiler specific issue, it happens. Should be fixed in master.

[Ali-RS]

Thanks.