-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
bugSomething that is supposed to work, but doesn't. More severe than a "defect".Something that is supposed to work, but doesn't. More severe than a "defect".
Description
I noticed there are two PostShadow Techniques in PBRLighting.j3md.
jmonkeyengine/jme3-core/src/main/resources/Common/MatDefs/Light/PBRLighting.j3md
Lines 199 to 266 in ffd9cfc
| Technique PostShadow{ | |
| VertexShader GLSL310 GLSL300 GLSL150: Common/MatDefs/Shadow/PostShadow.vert | |
| FragmentShader GLSL310 GLSL300 GLSL150: Common/MatDefs/Shadow/PostShadow.frag | |
| WorldParameters { | |
| WorldViewProjectionMatrix | |
| WorldMatrix | |
| ViewProjectionMatrix | |
| ViewMatrix | |
| } | |
| Defines { | |
| HARDWARE_SHADOWS : HardwareShadows | |
| FILTER_MODE : FilterMode | |
| PCFEDGE : PCFEdge | |
| DISCARD_ALPHA : AlphaDiscardThreshold | |
| SHADOWMAP_SIZE : ShadowMapSize | |
| SHADOWMAP_SIZE : ShadowMapSize | |
| FADE : FadeInfo | |
| PSSM : Splits | |
| POINTLIGHT : LightViewProjectionMatrix5 | |
| NUM_BONES : NumberOfBones | |
| INSTANCING : UseInstancing | |
| BACKFACE_SHADOWS: BackfaceShadows | |
| NUM_MORPH_TARGETS: NumberOfMorphTargets | |
| NUM_TARGETS_BUFFERS: NumberOfTargetsBuffers | |
| } | |
| ForcedRenderState { | |
| Blend Modulate | |
| DepthWrite Off | |
| PolyOffset -0.1 0 | |
| } | |
| } | |
| Technique PostShadow{ | |
| VertexShader GLSL100: Common/MatDefs/Shadow/PostShadow.vert | |
| FragmentShader GLSL100: Common/MatDefs/Shadow/PostShadow.frag | |
| WorldParameters { | |
| WorldViewProjectionMatrix | |
| WorldMatrix | |
| ViewProjectionMatrix | |
| ViewMatrix | |
| } | |
| Defines { | |
| HARDWARE_SHADOWS : HardwareShadows | |
| FILTER_MODE : FilterMode | |
| PCFEDGE : PCFEdge | |
| DISCARD_ALPHA : AlphaDiscardThreshold | |
| SHADOWMAP_SIZE : ShadowMapSize | |
| FADE : FadeInfo | |
| PSSM : Splits | |
| POINTLIGHT : LightViewProjectionMatrix5 | |
| NUM_BONES : NumberOfBones | |
| INSTANCING : UseInstancing | |
| BACKFACE_SHADOWS: BackfaceShadows | |
| NUM_MORPH_TARGETS: NumberOfMorphTargets | |
| NUM_TARGETS_BUFFERS: NumberOfTargetsBuffers | |
| } | |
| ForcedRenderState { | |
| Blend Modulate | |
| DepthWrite Off | |
| PolyOffset -0.1 0 | |
| } | |
| } |
It seems one of them relates to the so-called "PostShadow15" which is later merged into "PostShadow". It has already been removed from Lighting.j3md and Unshaded.j3md in this commit but seems is not removed from PBRLighting.j3md.
Metadata
Metadata
Assignees
Labels
bugSomething that is supposed to work, but doesn't. More severe than a "defect".Something that is supposed to work, but doesn't. More severe than a "defect".