Skip to content

GraphicsTracing/Timing on non-lwjgl backends #1278

@MeFisto94

Description

@MeFisto94

I think I found two nits to fix in GraphicsTrace:

gl = GLTracer.createGlesTracer(gl, GL.class, GLES_30.class, GLFbo.class, GLExt.class);

This misses GL2.class, which is implemented by
public class AndroidGL implements GL, GL2, GLES_30, GLExt, GLFbo {

And for JOGL:

gl = (com.jme3.renderer.opengl.GL) GLTiming.createGLTiming(gl, timingState, GL.class, GL2.class, GL3.class, GL4.class);

and the following address the wrong GL.class here, because GL.class is com.jogamp.opengl.GL, and not the com.jme3.renderer.opengl.GL (aka OpenGL 1 interface).

Both issues probably don't harm beyond instanceof Checks fail, but it could also be that the Proxy doesn't even hook the GL methods in that case, which would make this more critical.

On a similar sidenote: Why is there only GraphicsTrace for Android but no GraphicsTiming, which would also be interesting? Forgotten?

Sorry paul for again taking your time, but you are probably the only one knowing Proxies and I guess for you it's only a matter of 5 minutes then.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions