-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
I think I found two nits to fix in GraphicsTrace:
jmonkeyengine/jme3-android/src/main/java/com/jme3/system/android/OGLESContext.java
Line 217 in acbddc2
| gl = GLTracer.createGlesTracer(gl, GL.class, GLES_30.class, GLFbo.class, GLExt.class); |
This misses GL2.class, which is implemented by
jmonkeyengine/jme3-android/src/main/java/com/jme3/renderer/android/AndroidGL.java
Line 45 in acbddc2
| public class AndroidGL implements GL, GL2, GLES_30, GLExt, GLFbo { |
And for JOGL:
| gl = (com.jme3.renderer.opengl.GL) GLTiming.createGLTiming(gl, timingState, GL.class, GL2.class, GL3.class, GL4.class); |
and the following address the wrong GL.class here, because GL.class is
com.jogamp.opengl.GL, and not the com.jme3.renderer.opengl.GL (aka OpenGL 1 interface).
Both issues probably don't harm beyond instanceof Checks fail, but it could also be that the Proxy doesn't even hook the GL methods in that case, which would make this more critical.
On a similar sidenote: Why is there only GraphicsTrace for Android but no GraphicsTiming, which would also be interesting? Forgotten?
Sorry paul for again taking your time, but you are probably the only one knowing Proxies and I guess for you it's only a matter of 5 minutes then.