Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jme3-examples: PBRTerrainTest - typo in the ambient light color setting #2178

Closed
capdevon opened this issue Jan 4, 2024 · 0 comments · Fixed by #2181
Closed

jme3-examples: PBRTerrainTest - typo in the ambient light color setting #2178

capdevon opened this issue Jan 4, 2024 · 0 comments · Fixed by #2181
Assignees
Labels
examples specific to the jme3-examples sub-project
Milestone

Comments

@capdevon
Copy link
Contributor

capdevon commented Jan 4, 2024

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-examples/src/main/java/jme3test/terrain/PBRTerrainTest.java#L355

    private void setUpLights() {
        LightProbe probe = (LightProbe) assetManager.loadAsset("Scenes/LightProbes/quarry_Probe.j3o");

        probe.setAreaType(LightProbe.AreaType.Spherical);
        probe.getArea().setRadius(2000);
        probe.getArea().setCenter(new Vector3f(0, 0, 0));
        rootNode.addLight(probe);

        directionalLight = new DirectionalLight();
        directionalLight.setDirection((new Vector3f(-0.3f, -0.5f, -0.3f)).normalize());
        directionalLight.setColor(ColorRGBA.White);
        rootNode.addLight(directionalLight);

        ambientLight = new AmbientLight();
        directionalLight.setColor(ColorRGBA.White); //<- It should be ambientLight.setColor(ColorRGBA.White);
        rootNode.addLight(ambientLight);
    }
@capdevon capdevon changed the title jme3-examples: PBRTerrainTest- typo in the ambient light color setting jme3-examples: PBRTerrainTest - typo in the ambient light color setting Jan 4, 2024
@stephengold stephengold added the examples specific to the jme3-examples sub-project label Jan 4, 2024
@stephengold stephengold added this to the Future Release milestone Jan 4, 2024
@stephengold stephengold self-assigned this Jan 4, 2024
stephengold added a commit that referenced this issue Jan 4, 2024
@stephengold stephengold linked a pull request Jan 4, 2024 that will close this issue
@stephengold stephengold modified the milestones: Future Release, v3.7.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples specific to the jme3-examples sub-project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants