Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderManager#renderViewPort method leaves a clipRect in the OpenGL state #2224

Closed
richardTingle opened this issue Mar 17, 2024 · 0 comments · Fixed by #2225
Closed

RenderManager#renderViewPort method leaves a clipRect in the OpenGL state #2224

richardTingle opened this issue Mar 17, 2024 · 0 comments · Fixed by #2225

Comments

@richardTingle
Copy link
Member

Within GLRenderer the renderViewPort method leaves a clipRect in the OpenGL state. This means that other calls to GLRenderer #copyFrameBuffer may give surprising (clipped) results

GLRenderer#renderViewPort should clear the clipRect state once it has finished its render

See https://hub.jmonkeyengine.org/t/blitted-to-frame-buffer-only-copies-part-of-source/47564 for an example of the problem caused

(I intend to put in a PR for this myself)
@richardTingle richardTingle changed the title Renderer#renderViewPort method leaves a clipRect in the OpenGL state RenderManager#renderViewPort method leaves a clipRect in the OpenGL state Mar 17, 2024
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Mar 17, 2024
@richardTingle
jMonkeyEngine#2224 Fix bug where the clipRect would be left in the op…
8ae3728 
…enGL state leading to surprising (clipped) results when later using GLRenderer#copyFrameBuffer
@richardTingle richardTingle mentioned this issue Mar 17, 2024
Merged
scenemax3d pushed a commit that referenced this issue Mar 30, 2024
@richardTingle
#2224 Fix bug where the clipRect would be left in the openGL state le…
7d5a10b 
…ading to surprising (clipped) results when later using GLRenderer#copyFrameBuffer (#2225)
scenemax3d pushed a commit that referenced this issue Mar 30, 2024
@richardTingle @scenemax3d
#2224 Fix bug where the clipRect would be left in the openGL state le…
3a1aa08 
…ading to surprising (clipped) results when later using GLRenderer#copyFrameBuffer (#2225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2224 Fix bug where the clipRect would be left in the openGL state richardTingle/jmonkeyengine
1 participant
@richardTingle