Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid-matrix4f-for-worldviewprojectionmatrix assertion is hard to diagose #2275

Closed
richardTingle opened this issue Jun 1, 2024 · 0 comments · Fixed by #2276
Closed

Invalid-matrix4f-for-worldviewprojectionmatrix assertion is hard to diagose #2275

richardTingle opened this issue Jun 1, 2024 · 0 comments · Fixed by #2276
Labels
enhancement
Milestone
v3.7.0

Comments

@richardTingle
Copy link
Member

As seen in https://hub.jmonkeyengine.org/t/solved-error-invalid-matrix4f-for-worldviewprojectionmatrix/47680 and https://hub.jmonkeyengine.org/t/jmonkeyengine-v3-7-0-beta1-release/47653/12 the new assertion in GLRenderer catches incorrect setting of an objects position to infinity or NaN. However the assertion doesn't give much of a clue where the mistake was made. Just that it has.

I'm proposing adding some assertions to the Transform class in order to catch these mistakes "when they go in".
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 Improve assertions for invalid transforms.
87a2490 
These are already caught by assertions in GLRenderer, but by that time it is unclear what call pushed in the bad values
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 Improve assertions for invalid transforms.
6864557 
These are already caught by assertions in GLRenderer, but by that time it is unclear what call pushed in the bad values
@richardTingle richardTingle mentioned this issue Jun 1, 2024
Merged
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 Swap to use more generally available validation me…
fcaaf30 
…thods
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 Add license and javadoc
601a721
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 Correct copyright year
b4613a4
richardTingle added a commit to richardTingle/jmonkeyengine that referenced this issue Jun 1, 2024
@richardTingle
jMonkeyEngine#2275 It is a quaternion
58329b4
stephengold pushed a commit that referenced this issue Jun 1, 2024
@richardTingle
#2275 Improve assertions for invalid transforms. (#2276)
2c877fe 
* #2275 Improve assertions for invalid transforms.

These are already caught by assertions in GLRenderer, but by that time it is unclear what call pushed in the bad values

* #2275 Swap to use more generally available validation methods

* #2275 Add license and javadoc

* #2275 Correct copyright year

* #2275 It is a quaternion
scenemax3d pushed a commit that referenced this issue Jun 2, 2024
@richardTingle @scenemax3d
#2275 Improve assertions for invalid transforms. (#2276)
d13df22 
* #2275 Improve assertions for invalid transforms.

These are already caught by assertions in GLRenderer, but by that time it is unclear what call pushed in the bad values

* #2275 Swap to use more generally available validation methods

* #2275 Add license and javadoc

* #2275 Correct copyright year

* #2275 It is a quaternion
@stephengold stephengold added this to the v3.7.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging a pull request may close this issue.

#2275 Improve assertions for invalid transforms. richardTingle/jmonkeyengine
2 participants
@stephengold @richardTingle