Skip to content

Conversation

@stephengold
Copy link
Member

Per post-merge discussion of PR #1228, I propose re-publicizing the no-arg constructors for InstancedGeometry, LightNode, and CameraNode. Also removing/correcting the javadoc for these classes (plus Geometry and Node) since the no-arg constructors are apparently NOT serialization-only.

@pspeed42
Copy link
Contributor

pspeed42 commented Dec 3, 2019

Ok... so I looked into this deeper and I was wrong about CameraNode and LightNode. The way they are written, they are totally broken if you use the no-arg constructor so it should be protected. They internally use a control that is never created if you use the no-arg constructor. I'd argue that we should write them to be more flexible but I still think they are useless classes.

Sorry I didn't look at the whole class before commenting on them.

@stephengold
Copy link
Member Author

Thanks for looking. I'll amend the PR.

@stephengold stephengold changed the title re-publicize 3 no-arg constructors, correct/remove erroneous javadoc re-publicize InstancedGeometry no-arg constructor, correct erroneous javadoc Dec 3, 2019
@stephengold stephengold merged commit 98f6d32 into jMonkeyEngine:master Dec 4, 2019
@pspeed42
Copy link
Contributor

pspeed42 commented Dec 4, 2019

Thanks. I was waiting on this to make the 3.3 branch. :)

@stephengold
Copy link
Member Author

Huh. None of the other PRs seemed worth waiting for?

@pspeed42
Copy link
Contributor

pspeed42 commented Dec 5, 2019

I mean, this one was influx. I wasn't going to cut a release until Sunday night and then couldn't find my notes on how to do it. When I found it on Monday, this was still going back and forth so I thought I'd wait.

@stephengold stephengold added this to the v3.3.0 milestone Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants