Skip to content

Conversation

@syluna
Copy link
Contributor

@syluna syluna commented Apr 5, 2020

Remove all deprecated class and migrate to the new animation system.

Remove all deprecated class and migrate to the new animation system.
@Ali-RS
Copy link
Member

Ali-RS commented Apr 5, 2020

Thanks for PR.

It probably would be better to have both. You can separate them in two methods, testUsingOldAnimationSystem, testUsingNewAnimationSystem and by default set it to use the new animation system.

@pspeed42 are you agree that we should keep both tests?

@oxplay2
Copy link

oxplay2 commented Apr 5, 2020

are you sure, that we should have Deprecated animation system tests in 3.3+?

@Ali-RS
Copy link
Member

Ali-RS commented Apr 5, 2020

Yes, I think until the old animation system is not removed we should keep it's tests also. When we removed it then we can remove it's tests as well. This is just my opinion, so let's see what others think.

@oxplay2
Copy link

oxplay2 commented Apr 5, 2020

Paul and Darkchaos agreed on discord to keep only 3.3 related tests in 3.3+

reasons:

  • encourage people to use new due to find all issues that left.(bug finding)
  • people can anyway browse old tests

did you agree with this reasons?

@Ali-RS
Copy link
Member

Ali-RS commented Apr 5, 2020

Okay, fine then.

did you agree with this reasons?

Yes, it's ok.

@pspeed42
Copy link
Contributor

pspeed42 commented Apr 5, 2020

Yeah, specifically if the old tests start to disappear maybe folks reluctant to move for "some reason" will start panicking and making those reasons well known.

And from experience in my day job, if you leave bad code laying around, someone will cut and paste it into new code. It propagates like a virus sometimes. :)

@stephengold
Copy link
Member

Not providing tests/examples for deprecated methods is fine by me.

Thank you for your contribution, @syluna!

@stephengold stephengold merged commit bd4691e into jMonkeyEngine:master Apr 6, 2020
@stephengold stephengold added this to the v3.3.1 milestone Apr 19, 2020
@stephengold
Copy link
Member

Included in v3.3 branch at 68c6f71

@stephengold stephengold added the examples specific to the jme3-examples sub-project label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples specific to the jme3-examples sub-project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants