-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate TestSpatialAnim to the new Anim class #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove all deprecated class and migrate to the new animation system.
|
Thanks for PR. It probably would be better to have both. You can separate them in two methods, @pspeed42 are you agree that we should keep both tests? |
|
are you sure, that we should have Deprecated animation system tests in 3.3+? |
|
Yes, I think until the old animation system is not removed we should keep it's tests also. When we removed it then we can remove it's tests as well. This is just my opinion, so let's see what others think. |
|
Paul and Darkchaos agreed on discord to keep only 3.3 related tests in 3.3+ reasons:
did you agree with this reasons? |
|
Okay, fine then.
Yes, it's ok. |
|
Yeah, specifically if the old tests start to disappear maybe folks reluctant to move for "some reason" will start panicking and making those reasons well known. And from experience in my day job, if you leave bad code laying around, someone will cut and paste it into new code. It propagates like a virus sometimes. :) |
|
Not providing tests/examples for deprecated methods is fine by me. Thank you for your contribution, @syluna! |
|
Included in v3.3 branch at 68c6f71 |
Remove all deprecated class and migrate to the new animation system.