Skip to content

Conversation

@Grabli66
Copy link
Contributor

@Grabli66 Grabli66 commented Apr 6, 2020

It fixes error of loading assets in examples.

@stephengold
Copy link
Member

Please explain how moving the file.exists() into simpleInitApp() fixes an error. What error? Under what circumstances does the error manifest?

@Grabli66
Copy link
Contributor Author

Grabli66 commented Apr 6, 2020

Static method main does not calling from the launcher. And that is why "useHttp" is always false. Because of that assets can't be loaded from the internet. And i am getting error that "wildhouse.zip" or "quake3level.zip" not found.

@MeFisto94
Copy link
Member

See for example the TestMultipleFilters.
I got the report on Discord and asked them to do the PR here.

Debugging showed that the Test Chooser does not call the main method, but just instantiates the Test as Application and starts that. I mean it's obvious, it cannot guess for any potential main methods etc.

The only thing we discussed was that we might want a redesign for those tests to use test-data and/or to have some caching for HTTPable resources. Also when google shuts down it's google code archive, we'd potentially loose those assets. But that's the topic of a future PR/Issue, this fixes the test because main() is not called from the TestChooser. We might want to double check every Test for that.

@stephengold stephengold merged commit fafe8a7 into jMonkeyEngine:master Apr 6, 2020
@stephengold stephengold added this to the v3.3.1 milestone Apr 19, 2020
@stephengold
Copy link
Member

Included in the v3.3 branch at 21cbdb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants