Packing AO in the metallic roughness map #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated frag shader to support reading the AmbientOcclusion value from the Red channel of the packed MetallicRoughness map. Added a single boolean define that does this when set to true, so long as a metallic roughness map is also defined.
riccardobl
requested changes
Oct 10, 2020
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Can you merge your other PR ( #1404 ) to this one?
jme3-core/src/main/resources/Common/MatDefs/Light/PBRLighting.frag
Outdated
Show resolved
Hide resolved
jme3-core/src/main/resources/Common/MatDefs/Light/PBRLighting.frag
Outdated
Show resolved
Hide resolved
Member
Author
|
I updated the name of the vec3 to aoRoughnessMetallicValue, and also switched the code to work how you suggested, so that the normal light map code is unaltered. |
Member
Author
|
I could not find how to merge my other PR - but I managed to update this PR's branch to include the changes to PBRLighting.j3md that were in the closed pull request |
Member
|
Perfect! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated frag shader to support reading the AmbientOcclusion value from the Red channel of the packed MetallicRoughness map.
Adds a single boolean define that does this when set to true, so long as a metallic roughness map is also defined.
In response to this open issue:
#999