Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of a GlowColor with GlowMap #1444

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Allow use of a GlowColor with GlowMap #1444

merged 1 commit into from
Dec 20, 2020

Conversation

Ali-RS
Copy link
Member

@Ali-RS Ali-RS commented Dec 13, 2020 •
edited
Loading

In the case of grayscale GlowMap, GlowColor can be used for changing color without manipulating glow texture.

Forum topic: https://hub.jmonkeyengine.org/t/glowcolor-unused-if-a-glowmap-is-specified/44002

@Ali-RS Ali-RS changed the title Use GlowColor as a multiplier for GlowMap in Glow.frag shader Letting to use a GlowColor with GlowMap Dec 13, 2020
@stephengold stephengold changed the title Letting to use a GlowColor with GlowMap Allow use of a GlowColor with GlowMap Dec 13, 2020
@Ali-RS
Copy link
Member Author

Ali-RS commented Dec 19, 2020 •
edited
Loading

Going to merge this in 24h if no objection arises.

@Ali-RS Ali-RS merged commit 8c77f33 into jMonkeyEngine:master Dec 20, 2020
@stephengold stephengold added this to the v3.4.0 milestone Mar 13, 2021
@Ali-RS Ali-RS mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobl riccardobl riccardobl approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ali-RS @riccardobl @stephengold