Skip to content

Conversation

@Sailsman63
Copy link
Contributor

@Sailsman63 Sailsman63 commented Jan 22, 2021

This came out of some of the testing I did regarding the failing Github Actions builds.

Hopefully, these changes will make troubleshooting such issues a little simpler in the future:

  • The original failure erroneously seemed to be originating in the "Build Natives" step, though it was actually an error the Java build step. It is not necessary to build the full engine at this stage, as the result was merely discarded and then repeated during the OS matrix phase a little further down. I suspect that the line that caused this to happen was not intentional in the first place.
  • When a single part of a build matrix fails, we really should let all variants complete, rather than bailing early. This allows us to get as much data out of a build run as we can by comparing and contrasting the error messages
    • Also should improve on "Can't reproduce on my Machine" issues - We'll at least know which platforms are seeing the issue in the first place
  • On occasion, JME swallows exceptions and only logs the error. Bumping the gradle build to log level INFO will get us more of these types of errors. The downside is a larger build log to comb through, but if the build is green, do we really care? And if it's not, the info can be useful.

Copy link
Member

@stephengold stephengold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@stephengold stephengold merged commit 6c1bd8e into jMonkeyEngine:master Feb 1, 2021
@stephengold stephengold added this to the v3.4.0 milestone Mar 13, 2021
@stephengold stephengold added the buildscript An issue with the buildscript label Mar 13, 2021
@Sailsman63 Sailsman63 deleted the workflow-updates branch March 8, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildscript An issue with the buildscript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants