fix incorrect input cursor position on MacOS with retina screen in use #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let a 3 bytes UTF-8 data = [0xE4, 0x8A, 0xBC], when b = 0xE4 (1110 0100), it will be treated as 2 bytes.
See this part:
```java
if (b < 0x80) {
// good
}
else if ((b & 0xC0) == 0xC0) {// (0xE4 & 0xC0) == 0xC0 =====> true
utf8State = UTF8_2BYTE;
}
else if ((b & 0xE0) == 0xE0) {// (0xE4 & 0xE0) == 0xE0 =====> true
utf8State = UTF8_3BYTE_1;
}
else {
utf8State = UTF8_ILLEGAL;
}
```
3 bytes UTF-8 data while always be treated as 2 bytes UTF-8 data.
It's better that always treat String data as UTF-8 now.
see https://hub.jmonkeyengine.org/t/code-error-on-checking-utf-8-data/43909
…ll resolution framebuffers on Retina Display
…e don't get any callback when it is changed.So just get it from time to time when mouse cursor is moved.
|
Is this ready for review or integration? If not, please mark it as a draft. |
It's ready, sir. |
tonihele
reviewed
Sep 26, 2021
tonihele
reviewed
Sep 26, 2021
tonihele
reviewed
Sep 26, 2021
jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java
Outdated
Show resolved
Hide resolved
tonihele
reviewed
Sep 26, 2021
|
@tonihele please continue the conversations you started or else mark them as "resolved". |
|
Yep, sorry it took so long. |
|
Unless there are objections, this will be integrated in about 24 hours. |
tonihele
approved these changes
Nov 11, 2021
|
Changed the default setting for "UseRetinaFrameBuffer" to |
|
Further fixes proposed in PR #1746. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, with retina screen in use, the input cursor position is incorrect. As the window size is not equals to camera resolution.
This PR use glfwGetWindowContentScale to get the scaling factor on window resolution, and apply it to GlfwMouseInput#onCursorPos callback. So we have the correct cursor position on MacOS.
For more information, there are the links:
This PR is also trying to fix part of issue #893