Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and test for issue 1723 (more serialization bugs in RenderState) #1726

Merged
merged 4 commits into from
Jan 3, 2022
Merged

fix and test for issue 1723 (more serialization bugs in RenderState) #1726

merged 4 commits into from
Jan 3, 2022

Conversation

stephengold
Copy link
Member

The solves issue 1723 and adds a JUnit test to check for similar bugs in RenderState serialization and/or cloning.

@stephengold stephengold added this to the v3.5.0 milestone Dec 27, 2021
@stephengold stephengold linked an issue Dec 27, 2021 that may be closed by this pull request
more serialization bugs in RenderState #1723
Closed
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Dec 27, 2021
@stephengold
Copy link
Member Author

Unless there's substantial discussion, I plan to integrate this PR in about 24 hours.

@stephengold stephengold merged commit a8a7080 into master Jan 3, 2022
@stephengold stephengold deleted the sgold/issue-1723 branch January 3, 2022 23:25
stephengold added a commit that referenced this pull request Jan 9, 2022
@stephengold
fix and test for issue 1723 (more serialization bugs in RenderState) (#…
8e449e7 
…1726)

* RenderStateTest:  add automated tests for cloning/serialization issues

* RenderState:  solve issue #1723 (serialization bugs)

* RenderStateTest:  enable testing of serialization

* RenderStateTest:  don't use floating point for loop indices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

more serialization bugs in RenderState
1 participant
@stephengold