-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error 1280 in MacOS when querying GL_FRAMEBUFFER_SRGB_CAPABLE_EXT #1749
Conversation
jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Outdated
Show resolved
Hide resolved
4551bdd
to
f27b663
Compare
I reconsidered this PR, it just removes a warning, so it is better to exclude all the mac os platforms, worst case scenario: the devs won't receive a warning when using sRGB on unsupported deprecated platforms, not a big deal. There isn't a way to get the generic os name (ie without the arch) from Platform in jme, so i've added that aswell, it will be useful to apply os specific workarounds across the engine. |
Another way to determine the OS is to invoke |
We can't use org.lwjgl.system.Platform outside of the jme3-lwjgl3 modules |
Regarding "Platform.java", I have some style requests:
|
done |
Ready for integration, I think. |
Thanks, Riccardo! |
The line
getBoolean(GLExt.GL_FRAMEBUFFER_SRGB_CAPABLE_EXT)
in GLRenderer throw an opengl error 1280 (invalid enum) when the GL debugger is enabled.I am not sure why this is the case, however i believe it is safe to assume that every modern macos device is sRGB capable.