Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform fix for issue 1745 (mouse input scaling) #1753

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

riccardobl
Copy link
Member

Fix issue #1745

@bob0bob
Copy link
Contributor

bob0bob commented Jan 18, 2022

This fix works for me after getting rid of the "saved" settings, because JME already set it to "true" by default and re-running brought them back, but when I erased the settings, it worked great.

@stephengold stephengold added this to the v3.5.0 milestone Jan 18, 2022
@stephengold
Copy link
Member

I tested this on Windows 11 with display scaling set to 150%, and it worked.

Question: do the GlfwMouseInputVR and LwjglWindowVR classes in jme-vr need similar modifications?

@stephengold stephengold changed the title Cross-platform fix Scaling issue #1745 Cross-platform fix for issue 1745 (mouse input scaling) Jan 18, 2022
@riccardobl
Copy link
Member Author

It's better to address that in a future PR, because the VR implementation doesn't seem to have any code regarding scaling and high DPI.

@stephengold
Copy link
Member

In that case, I believe this PR is ready to be integrated into "master".

@riccardobl riccardobl merged commit 71269bb into jMonkeyEngine:master Jan 18, 2022
@stephengold
Copy link
Member

Thank you, Riccardo!

stephengold pushed a commit that referenced this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants