jme3-nifty should account for gamma correction #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
added
the
defect
|
Here's a screenshot of how ...and here's how it was intended to look (how it looked with gamma correction disabled): Note how gamma correction made the left side of the scrollpanel too bright. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue with jme3-nifty not taking gamma correction into account. Nifty UIs specify colors by their red, green, and blue components. In order for jme3-nifty to display these colors property, it needs to know whether gamma correction is enabled or not.
If gamma correction is enabled, the application should specify
ColorSpace.sRGB, in which caseColorRGBA.setAsSrgb()will be used to convert Nifty colors to JME colors.If gamma correction is not enabled, the application should use the old constructor or specify
ColorsSpace.Linear, in which caseColorRGBA.set()will be used to convert Nifty color to JME colors.