-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid use of deprecated methods (mostly Class.newInstance()) #1774
avoid use of deprecated methods (mostly Class.newInstance()) #1774
Conversation
"Remove deprecated code" is a bit misleading. Most of the changes seem to be replacing The corrections to |
Doesn't seem to show those as merge conflicts, so auto-merge will probably go just fine. However if this still bothers, I can try tomorrow to revert the file, seems best to use some GIT magic since I can't revert a whole commit (too big commits), just the file in the commit. I adjusted the PR title and also added a better description of the changes. I also cleaned up the Android project which I was a bit hesitant to do yesterday, since the Java versions on Android.... But these methods are present all in Java 8 at least so I guess everything is fine in that regard. The code base is surprisingly fine in the deprecation regard for a project of this size (and age). Seems to be mostly now internal deprecations about the animation system and the framebuffer change. |
@tonihele do you believe this PR is ready to be integrated? |
I think so. I didn't have the chance to revert the file you asked. But it looks to me that it will go just fine, without any conflict. So there should be no need to revert the file. |
Thanks for your contribution, @tonihele! |
Removes deprecated code and some warnings.
Compiled with JDK 11 (-Xlint:deprecation)...